search

wagtail / sphinx-wagtail-theme

Sphinx theme for Wagtail
https://sphinx-wagtail-theme.readthedocs.io/
MIT License
28 stars 28 forks source link

Upgrade Bootstrap to version 5 #254

Open lb- opened 1 year ago

lb- commented 1 year ago

Currently the Theme is using Bootstrap 4 and it would be good to upgrade to version 5.

Split from #252 / #250

Bootstrap 5 did remove jquery as a dependency. Not sure how broken that would be to upgrade, or if it would be a mostly drop-in replacement given our minimal bootstrap usage. https://getbootstrap.com/docs/5.2/migration/ _Originally posted by @vsalvino in https://github.com/wagtail/sphinx_wagtail_theme/issues/252#issuecomment-1460813826_

It may be worth considering a small clean up of unused styles in the process. See https://github.com/wagtail/sphinx_wagtail_theme/issues/64

dassudip2001 commented 1 year ago

it used Bootstrap CDN ??

lb- commented 1 year ago

It's a front-end dependency see https://github.com/wagtail/sphinx_wagtail_theme/blob/main/package.json#L23

dassudip2001 commented 1 year ago

Screenshot from 2023-03-13 09-44-18

i can fix it ? can i send a PR

lb- commented 5 months ago

Just a thought. Is it worth looking at something more lightweight instead of Bootstrap.

Maybe too lightweight - https://open-props.style/ - but super flexible with CSS Custom Properties as the core method of designs.

Not sure on other options, maybe we need to review the actual Bootstrap parts used.

Also need to consider the ability to customise and override things for others.