search

wagtail / sphinx-wagtail-theme

Wagtail's documentation theme for Sphinx
https://sphinx-wagtail-theme.readthedocs.io/
MIT License
30 stars 29 forks source link

Update frontend tooling to use Node 20 #273

Closed lb- closed 8 months ago

lb- commented 1 year ago

Ensure we are on the latest LTS of Node for frontend tooling.

See https://github.com/wagtail/wagtail/pull/11141 (Wagtail core update)

lb- commented 1 year ago

OK this may be blocked by Vercel not supporting Node 20 yet.

Screenshot 2023-11-12 at 3 18 01 pm

https://vercel.com/docs/functions/serverless-functions/runtimes/node-js#node.js-version

https://github.com/vercel/pkg/discussions/1972

lb- commented 10 months ago

Ok. We might be able to use Node 20 now in Vercel.

https://vercel.com/changelog/nodejs-20

lb- commented 10 months ago

OK not sure here, will have to review again later.

Changing Vercel to Node 20 was breaking all the builds so I have just turned it back off for now.

Warning: Detected "engines": { "node": ">=20" } in your `package.json` that will automatically upgrade when a new major Node.js Version is released. Learn More: http://vercel.link/node-version
Error: Command "npm install && python3 -m pip install -r requirements.txt && pip install "urllib3<2" && python3 -m pip install -e ." exited with 1
laymonage commented 9 months ago

Oops, I didn't see that we don't use Node 20 yet. I updated the RTD config to use Node 20 in #284 , builds OK (with some warnings) but I assume we'll want to update it anyway.

lb- commented 9 months ago

I think that's fine, it's just Vercel taking a bit to make their Node 20 support official.