wagtail / sphinx-wagtail-theme

Wagtail's documentation theme for Sphinx
https://sphinx-wagtail-theme.readthedocs.io/
MIT License
30 stars 29 forks source link

Search broken due to JavaScript "undefined" #274

Closed vsalvino closed 3 weeks ago

vsalvino commented 1 year ago

At some point, the search has been broken (the built-in search, not algolia from the wagtail docs).

It is injecting "undefined" into the URLs when jumping to a specific page.

I'll investigate later whether this is due to a sphinx change or a JS change in our theme.

Example: https://docs.coderedcorp.com/wagtail-crx/index.html

image

lb- commented 1 year ago

It does not seem to happen on the deployed version here https://sphinx-wagtail-theme.readthedocs.io/

chintanp commented 7 months ago

@vsalvino were you able to resolve this? I am facing the same issue,

vsalvino commented 5 months ago

The deployed version was not using the latest version. It seems to have been recently deployed and now is exhibiting the issue.

image

vsalvino commented 5 months ago

Did a bit more digging... turns out this broke due to a change in Sphinx 7.2. I'm still tracing down the fix, but as a workaround, build with sphinx<7.2

laymonage commented 3 weeks ago

Now that #284 is merged, the deployed version also exhibits this bug:

https://github.com/user-attachments/assets/0dc9818b-efe3-4d21-aafc-f9b4e509a976