wagtail / sphinx-wagtail-theme

Wagtail's documentation theme for Sphinx
https://sphinx-wagtail-theme.readthedocs.io/
MIT License
30 stars 29 forks source link

Wagtail@latest is using default Read the Docs favicon #277

Closed smark-1 closed 10 months ago

smark-1 commented 10 months ago

On https://docs.wagtail.org/en/stable/ the favicon in the browser looks like image but when I visit https://docs.wagtail.org/en/latest/ the icon shows the default Read the Docs favicon. image

laymonage commented 10 months ago

Thanks for the report! Looks like this is an issue for our Sphinx theme. The favicon template variable has been replaced with favicon_url: https://www.sphinx-doc.org/en/master/extdev/deprecated.html. We need to update the following lines:

https://github.com/wagtail/sphinx-wagtail-theme/blob/841c0cf618541a40d6833091fd8d98d5db71d0da/sphinx_wagtail_theme/layout.html#L26-L28

See also: https://github.com/sphinx-doc/sphinx/issues/11062