wagtail / sphinx-wagtail-theme

Wagtail's documentation theme for Sphinx
https://sphinx-wagtail-theme.readthedocs.io/
MIT License
30 stars 29 forks source link

Fix favicon URL #282

Closed laymonage closed 9 months ago

laymonage commented 9 months ago

Fixes #281

laymonage commented 9 months ago

Hmm looks like we can't rely on the Vercel preview, as the favicon works correctly there, even with the current main branch e.g.: https://sphinx-wagtail-theme.vercel.app/examples/code-blocks.html

Probably because readthedocs config for Wagtail would add the locale and version, whereas our config for this repo only has the latest version and without the locale.

laymonage commented 9 months ago

OK, can confirm this fixes the issue:

https://sphinx-wagtail-theme--282.org.readthedocs.build/en/282/examples/index.html

image

Compare to current main:

https://sphinx-wagtail-theme.readthedocs.io/en/latest/examples/index.html

image