Closed Stormheg closed 2 months ago
I've just set up the Trusted Publisher in the PyPI interface.
I'm not sure why Vercel is failing. I don't have access and cannot view the logs.
I stumbled on https://github.com/wagtail/sphinx-wagtail-theme/issues/226#issuecomment-1462422734 which mentions that the latest
version on read the docs is actually built from the gh-pages
. Removing the GitHub Pages build from the CI will break that integration
Looks like I'll have to consider if there is an alternate way of building the latest version of the theme, or bring back the Pages build.
@Stormheg I fixed the readthedocs config to also build the frontend assets in #284, so I think that might be irrelevant now. I suppose the reason why we had the Vercel setup was also because we didn't have the setup to build the frontend assets for PR builds on readthedocs. Now that it's been fixed, we can probably remove both of them.
Thanks both for making this better.
@laymonage I suppose you are right and we don't need Vercel anymore. I've removed the integration.
Attempts to declutter the project and ease maintenance.
Makefile
which I believe are rarely used. Less is better.Remove the Github Pages deployment, this does not appear to be usedactually used to build the thelatest
version on Read the Docszest.releaser
. (which provides theprerelease
andpostrelease
commands mentioned in the original documentation). We don't use tools like this much in other projects and I think it is best to just remove it (for consistency and to avoid confusion)