wagtail / sphinx-wagtail-theme

Wagtail's documentation theme for Sphinx
https://sphinx-wagtail-theme.readthedocs.io/
MIT License
30 stars 29 forks source link

Automated publishing, Makefile cleanup, Black, improved release instructions #286

Closed Stormheg closed 2 months ago

Stormheg commented 8 months ago

Attempts to declutter the project and ease maintenance.

Stormheg commented 8 months ago

I've just set up the Trusted Publisher in the PyPI interface.

Stormheg commented 8 months ago

I'm not sure why Vercel is failing. I don't have access and cannot view the logs.

Stormheg commented 8 months ago

I stumbled on https://github.com/wagtail/sphinx-wagtail-theme/issues/226#issuecomment-1462422734 which mentions that the latest version on read the docs is actually built from the gh-pages. Removing the GitHub Pages build from the CI will break that integration

Looks like I'll have to consider if there is an alternate way of building the latest version of the theme, or bring back the Pages build.

laymonage commented 8 months ago

@Stormheg I fixed the readthedocs config to also build the frontend assets in #284, so I think that might be irrelevant now. I suppose the reason why we had the Vercel setup was also because we didn't have the setup to build the frontend assets for PR builds on readthedocs. Now that it's been fixed, we can probably remove both of them.

lb- commented 8 months ago

Thanks both for making this better.

Stormheg commented 8 months ago

@laymonage I suppose you are right and we don't need Vercel anymore. I've removed the integration.