search

wagtail / sphinx-wagtail-theme

Wagtail's documentation theme for Sphinx
https://sphinx-wagtail-theme.readthedocs.io/
MIT License
30 stars 29 forks source link

Fix search bug with Sphinx>=7.2 #291

Closed vsalvino closed 2 weeks ago

vsalvino commented 5 months ago

Fixes #274

See relevant change in sphinx: https://github.com/sphinx-doc/sphinx/commit/8e730ae303ae686705ea12f44ef11da926a87cf5

laymonage commented 2 weeks ago

I can confirm that this works with Sphinx v8.1.3 as per the deployed preview:

https://github.com/user-attachments/assets/1073506b-179c-4dda-8111-7037695be175

and it also works with an older version of Sphinx e.g. 7.1.2

https://github.com/user-attachments/assets/aaae44cc-66b1-4acb-9e0b-4a2d5b548fc1

lb- commented 2 weeks ago

Thank you all! What an incredible bunch of digging.

Should we try to document any of this somewhere? Either in the docs or the readme?