search

wagtail / sphinx-wagtail-theme

Wagtail's documentation theme for Sphinx
https://sphinx-wagtail-theme.readthedocs.io/
MIT License
30 stars 29 forks source link

New search dialog is quite thin on small devices #303

Open lb- opened 2 weeks ago

lb- commented 2 weeks ago

The new Read The Docs search adoption seems much simpler, however, the layout and styling needs some work.

Especially how thin it is on small devices.

Image

Something like width: min(95vw, 55rem); should be good for the .content but I am not sure if we can easily control these styles as it's in a custom component.

Also, I am not sure if the styles sass/_component_search.scss are still used, we should probably delete or clean up that file if it's not being used. Depending on how we want to tackle the responsibility of this theme to cover custom search still.

Relates to https://github.com/wagtail/sphinx-wagtail-theme/pull/299

laymonage commented 2 weeks ago

This might be something to raise at https://github.com/readthedocs/addons.

Also, I am not sure if the styles sass/_component_search.scss are still used, we should probably delete or clean up that file if it's not being used. Depending on how we want to tackle the responsibility of this theme to cover custom search still.

We can't assume the docs are hosted on RTD, so this still has some value. Unless we want to just use the built-in search.html page from Sphinx.

lb- commented 2 weeks ago

Good call about the different searching approaches.

I've not seen a bug on readthedocs add-ons that's the same as this but here's two similar ones.

https://github.com/readthedocs/addons/issues/419

https://github.com/readthedocs/addons/issues/292

I'll look at making a seperate bug on that repo soon.

lb- commented 2 weeks ago

Issue raised. https://github.com/readthedocs/addons/issues/423