search

wagtail / wagtail-factories

Factory boy classes for wagtail
http://wagtail-factories.readthedocs.io/en/latest/
MIT License
102 stars 40 forks source link

Define ListBlockFactory only once for factory-boy 3.2 support #44

Closed jeromelebleu closed 3 years ago

jeromelebleu commented 3 years ago

See https://github.com/marteinn/wagtail-factories/pull/1. This prevents multiple definitions of ListBlockFactory class which seems to work in all versions of factory-boy (>= 3.2 and lower).

marteinn commented 3 years ago

Thank you for this PR @jeromelebleu! I think your solution and code looks good, will do some testing before merging, will report back here once I've done that.

jeromelebleu commented 3 years ago

@marteinn You are welcome, more tests are indeed welcome before merging, thanks!

marteinn commented 3 years ago

Works great, thanks again @jeromelebleu! Merging.