Compatibility fix for Wagtail 4.1

wagtail / wagtail-factories

Factory boy classes for wagtail

http://wagtail-factories.readthedocs.io/en/latest/

MIT License

102 stars 41 forks source link

Compatibility fix for Wagtail 4.1 #66

Closed johncarter-phntm closed 2 years ago

johncarter-phntm commented 2 years ago

See #65

Is this a sensible approach?

If confirmed this approach is good, would also need to:

[ ] Fix tests (eg [] -> ListValue(...)
[ ] Fix or drop Wagtail < 3.0 support

jams2 commented 2 years ago

Hi @johncarter-phntm ,

thanks for raising this!

It looks like this approach will work. It seems that we should have been returning a ListValue from ListBlockFactory already. This was changed in Wagtail in 2.16.

We shouldn't drop Wagtail 2.15 support until Feb 2023 (see the release schedule).

jams2 commented 2 years ago

@johncarter-phntm closing this in favour of https://github.com/wagtail/wagtail-factories/pull/68 - thanks for your contributions so far.