wagtail / wagtail-factories

Factory boy classes for wagtail
http://wagtail-factories.readthedocs.io/en/latest/
MIT License
102 stars 40 forks source link

Wagtail 6.1 - Minor updates #91

Closed katdom13 closed 3 months ago

katdom13 commented 3 months ago

Notes

Wagtail 6.1 upgrade check list ## Code reviewing a consideration. Use the tick box to indicate a consideration has been code reviewed as OK ### What’s new - [ ] [Universal listings continued](https://docs.wagtail.org/en/latest/releases/6.1.html#universal-listings-continued) - [ ] [Information-dense admin interface](https://docs.wagtail.org/en/latest/releases/6.1.html#information-dense-admin-interface) - [ ] [Custom per-page-type listings](https://docs.wagtail.org/en/latest/releases/6.1.html#custom-per-page-type-listings) - [ ] [Keyboard shortcuts overview](https://docs.wagtail.org/en/latest/releases/6.1.html#keyboard-shortcuts-overview) - [ ] [Better guidance for password-protected content](https://docs.wagtail.org/en/latest/releases/6.1.html#better-guidance-for-password-protected-content) - [ ] [Favicon images generation](https://docs.wagtail.org/en/latest/releases/6.1.html#favicon-images-generation) - [ ] [Cve-2024-32882: permission check bypass when editing a model with per-field restrictions through wagtail.contrib.settings or modelviewset](https://docs.wagtail.org/en/latest/releases/6.1.html#cve-2024-32882-permission-check-bypass-when-editing-a-model-with-per-field-restrictions-through-wagtail-contrib-settings-or-modelviewset) - [ ] [Other features](https://docs.wagtail.org/en/latest/releases/6.1.html#other-features) - [ ] [Bug fixes](https://docs.wagtail.org/en/latest/releases/6.1.html#bug-fixes) - [ ] [Documentation](https://docs.wagtail.org/en/latest/releases/6.1.html#documentation) - [ ] [Maintenance](https://docs.wagtail.org/en/latest/releases/6.1.html#maintenance) ### Changes affecting wagtail customizations - [ ] [Changes to submissionslistview class](https://docs.wagtail.org/en/latest/releases/6.1.html#changes-to-submissionslistview-class) - [ ] [Register_user_listing_buttons hook signature changed](https://docs.wagtail.org/en/latest/releases/6.1.html#register-user-listing-buttons-hook-signature-changed) - [ ] [Password_required_template has changed to wagtail_password_required_template](https://docs.wagtail.org/en/latest/releases/6.1.html#password-required-template-has-changed-to-wagtail-password-required-template) - [ ] [Document_password_required_template has changed to wagtaildocs_password_required_template](https://docs.wagtail.org/en/latest/releases/6.1.html#document-password-required-template-has-changed-to-wagtaildocs-password-required-template) ### Changes to undocumented internals - [ ] [Deprecation of user_listing_buttons template tag](https://docs.wagtail.org/en/latest/releases/6.1.html#deprecation-of-user-listing-buttons-template-tag) - [ ] [Deprecation of wagtailusers_groups:users url pattern](https://docs.wagtail.org/en/latest/releases/6.1.html#deprecation-of-wagtailusers-groups-users-url-pattern) - [ ] [Deprecation of window.chooserurls within draftail choosers](https://docs.wagtail.org/en/latest/releases/6.1.html#deprecation-of-window-chooserurls-within-draftail-choosers) - [ ] [Deprecation of window.initblockwidget to initialize a streamfield block](https://docs.wagtail.org/en/latest/releases/6.1.html#deprecation-of-window-initblockwidget-to-initialize-a-streamfield-block) - [ ] [Old](https://docs.wagtail.org/en/latest/releases/6.1.html#id1) - [ ] [New](https://docs.wagtail.org/en/latest/releases/6.1.html#id2) - [ ] [Removal of jquery from base client-side widget and boundwidget classes](https://docs.wagtail.org/en/latest/releases/6.1.html#removal-of-jquery-from-base-client-side-widget-and-boundwidget-classes) - [ ] [Window.urlify deprecated](https://docs.wagtail.org/en/latest/releases/6.1.html#window-urlify-deprecated) - [ ] [Window.xregexp polyfill removed](https://docs.wagtail.org/en/latest/releases/6.1.html#window-xregexp-polyfill-removed)
nickmoreton commented 3 months ago

Hi @katdom13 I think it might be a good time to overhaul some testing dependencies. I tried this locally in setup.py

docs_require = [
    "sphinx==7.1.2",
]

tests_require = [
    "pytest==8.2.1",
    "pytest-django==4.8.0",
    "pytest-cov==5.0.0",
    "pytest-pythonpath==0.7.3",
    "coverage==7.5.1",
    "ruff==0.4.4",
]

The docs seemed to build OK but there was a configuration warning that might need attention.

The tests might fail but there's some clues about that here: https://github.com/wagtail/wagtail-factories/pull/89

katdom13 commented 3 months ago

Hi @katdom13 I think it might be a good time to overhaul some testing dependencies. I tried this locally in setup.py

docs_require = [
    "sphinx==7.1.2",
]

tests_require = [
    "pytest==8.2.1",
    "pytest-django==4.8.0",
    "pytest-cov==5.0.0",
    "pytest-pythonpath==0.7.3",
    "coverage==7.5.1",
    "ruff==0.4.4",
]

The docs seemed to build OK but there was a configuration warning that might need attention.

The tests might fail but there's some clues about that here: #89

Hi @nickmoreton , Thanks, I've updated those in one of the newest commits. I also updated the workflows, but I know this will throw an error on publish. I left a comment as to why: https://github.com/wagtail/wagtail-factories/pull/91#discussion_r1609222803