search

wagtail / wagtail-generic-chooser

A toolkit for custom chooser popups in Wagtail
BSD 3-Clause "New" or "Revised" License
116 stars 25 forks source link

Expected UI issues with Wagtail 3.0 release #50

Closed thibaudcolas closed 2 years ago

thibaudcolas commented 2 years ago

The Wagtail 3.0 first release candidate is out. There are large UI changes in this release, for which we have reviewed expected breakage in third-party UI customisations.

This is beyond what we do with our normal breaking changes policy, since the majority of those changes are on parts of Wagtail that haven’t been publicly supported / documented in any way. To make sure this goes smoothly anyway, I’m here to provide an advance notice of what we’re aware of with this specific package 🙂

In the case of wagtail-generic-chooser, the main issue is reliance on Wagtail’s internal tabs implementation:

wagtail/wagtail/wagtail-generic-chooser/generic_chooser/templates/generic_chooser/tabbed_modal.html
10:    <ul class="tab-nav merged" data-tab-nav>

Here is our guidance on replacing Bootstrap tabs, and our proposal for a tabs component API.

zerolab commented 2 years ago

Note that doing this won't be enough for 3.0 as initTabs() needs to be called within the modal. https://github.com/torchbox/wagtailmedia/pull/161 had to bundle the 3.0 tabs JS with a few minor changes

Probably not that big of an issue since this will soon become obsolete..

gasman commented 2 years ago

Completed in #53.