search

wagtail / wagtail-generic-chooser

A toolkit for custom chooser popups in Wagtail
BSD 3-Clause "New" or "Revised" License
116 stars 25 forks source link

Wagtail 3.0 support #52

Closed BrianXu20 closed 2 years ago

BrianXu20 commented 2 years ago

Ticket

Add support to Wagtail 3.0

nickmoreton commented 2 years ago

Hey @BrianXu20 Looks good to me and the tests run OK back to 2.15 👍

BrianXu20 commented 2 years ago

Hi @gasman , I saw you are on the contributor list, is this something that you can merge in and have a release? Thank you

gasman commented 2 years ago

Thanks @BrianXu20!

I see there are still some styling issues, as noted in #50: Screenshot 2022-06-10 at 14 22 04

Without a fix for these, it probably doesn't make sense to make a 3.0-compatible release, since the previous release is still functional on 3.0 even without the import updates - upgrading wouldn't provide any actual benefits.

gasman commented 2 years ago

Have now cherry-picked the import updates in 14502a7d5299bf1e2aed6363287599552a090e91. Given that this package is probably going to become obsolete pretty soon when Wagtail itself provides the same feature (hopefully in 4.0), I think there's not much value in dropping support for older Wagtail versions (which would imply creating a short-lived 1.0 series), so I'll leave that change out.