Wagtail 4.2 - Githubissues

wagtail / wagtail-generic-chooser

A toolkit for custom chooser popups in Wagtail

BSD 3-Clause "New" or "Revised" License

116 stars 25 forks source link

Wagtail 4.2 #69

Closed katdom13 closed 1 year ago

katdom13 commented 1 year ago

Release notes: https://docs.wagtail.org/en/stable/releases/4.2.html

Code cleanup
Removed code conditionals for Wagtail versions prior to 4.1 (according to this discussion, and this set of guidelines.)
Added entry in changelog
All tests run OK

Found 17 test(s).
Creating test database for alias 'default'...
System check identified no issues (0 silenced).
.................
----------------------------------------------------------------------
Ran 17 tests in 0.507s

OK

katdom13 commented 1 year ago

Hi @nickmoreton , Thank you for the review. I resolved the comments.

gasman commented 1 year ago

Thanks @katdom13! Just to confirm (since this PR is just removing code paths for older Wagtail releases), am I right in understanding that there are no compatibility issues with the current release under Wagtail 4.2 that would necessitate making a new release now, and we're OK to just keep these updates on the git main branch for now?

katdom13 commented 1 year ago

Hi @gasman , That should be OK.