wagtail / wagtail-localize

Translation plugin for Wagtail CMS
https://wagtail-localize.org/
Other
226 stars 86 forks source link

Improve authentication options for `GoogleCloudTranslator` #645

Closed ababic closed 1 year ago

ababic commented 1 year ago

This PR adds the CREDENTIALS_PATH and CREDENTIALS options to GoogleCloudTranslator, giving developers more control and (more importantly) a way to provide service account credentials when storing actual key files isn't an option.

codecov-commenter commented 1 year ago

Codecov Report

Base: 91.78% // Head: 91.66% // Decreases project coverage by -0.12% :warning:

Coverage data is based on head (8d4e1ce) compared to base (fb4db60). Patch coverage: 91.66% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #645 +/- ## ========================================== - Coverage 91.78% 91.66% -0.13% ========================================== Files 46 47 +1 Lines 3980 4006 +26 Branches 603 608 +5 ========================================== + Hits 3653 3672 +19 - Misses 194 200 +6 - Partials 133 134 +1 ``` | [Impacted Files](https://codecov.io/gh/wagtail/wagtail-localize/pull/645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wagtail) | Coverage Δ | | |---|---|---| | [wagtail\_localize/machine\_translators/google.py](https://codecov.io/gh/wagtail/wagtail-localize/pull/645/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wagtail#diff-d2FndGFpbF9sb2NhbGl6ZS9tYWNoaW5lX3RyYW5zbGF0b3JzL2dvb2dsZS5weQ==) | `78.26% <91.66%> (ø)` | | | [wagtail\_localize/side\_panels.py](https://codecov.io/gh/wagtail/wagtail-localize/pull/645/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wagtail#diff-d2FndGFpbF9sb2NhbGl6ZS9zaWRlX3BhbmVscy5weQ==) | `47.61% <0.00%> (-2.39%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wagtail). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wagtail)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.