search

wagtail / wagtail-localize

Translation plugin for Wagtail CMS
https://wagtail-localize.org/
Other
226 stars 86 forks source link

Rename imageChosen, documentChosen to chosen #650

Closed tspnn closed 1 year ago

tspnn commented 1 year ago

Fixes #649

After these commits choosers in the wagtail_localize didn't work correctly: https://github.com/wagtail/wagtail/commit/157f7674bcced9e134b1a80ab8c299d13d5dd833 https://github.com/wagtail/wagtail/commit/6dba0cf4476e3b86cc20233c4694e58e93f8da83

codecov-commenter commented 1 year ago

Codecov Report

Base: 91.73% // Head: 91.73% // No change to project coverage :thumbsup:

Coverage data is based on head (e7cd8fc) compared to base (1e1f72f). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #650 +/- ## ======================================= Coverage 91.73% 91.73% ======================================= Files 46 46 Lines 3983 3983 Branches 604 604 ======================================= Hits 3654 3654 Misses 195 195 Partials 134 134 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wagtail). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wagtail)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

tspnn commented 1 year ago

@zerolab any news on this?

zerolab commented 1 year ago

Hey @spikenn merged and releases v1.3.3 Sorry for the delay. Live got in the way