search

wagtail / wagtail-localize

Translation plugin for Wagtail CMS
https://wagtail-localize.org/
Other
222 stars 84 forks source link

Wagtail 4.2 upgrade #673

Closed katdom13 closed 1 year ago

katdom13 commented 1 year ago
codecov-commenter commented 1 year ago

Codecov Report

Base: 91.61% // Head: 93.05% // Increases project coverage by +1.43% :tada:

Coverage data is based on head (146b4e1) compared to base (1fc56b0). Patch coverage: 99.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #673 +/- ## ========================================== + Coverage 91.61% 93.05% +1.43% ========================================== Files 47 47 Lines 4008 3929 -79 Branches 609 581 -28 ========================================== - Hits 3672 3656 -16 + Misses 201 161 -40 + Partials 135 112 -23 ``` | [Impacted Files](https://codecov.io/gh/wagtail/wagtail-localize/pull/673?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wagtail) | Coverage Δ | | |---|---|---| | [wagtail\_localize/test/settings.py](https://codecov.io/gh/wagtail/wagtail-localize/pull/673?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wagtail#diff-d2FndGFpbF9sb2NhbGl6ZS90ZXN0L3NldHRpbmdzLnB5) | `100.00% <ø> (ø)` | | | [wagtail\_localize/compat.py](https://codecov.io/gh/wagtail/wagtail-localize/pull/673?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wagtail#diff-d2FndGFpbF9sb2NhbGl6ZS9jb21wYXQucHk=) | `81.25% <66.66%> (+29.39%)` | :arrow_up: | | [wagtail\_localize/components.py](https://codecov.io/gh/wagtail/wagtail-localize/pull/673?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wagtail#diff-d2FndGFpbF9sb2NhbGl6ZS9jb21wb25lbnRzLnB5) | `85.71% <100.00%> (+3.02%)` | :arrow_up: | | [wagtail\_localize/fields.py](https://codecov.io/gh/wagtail/wagtail-localize/pull/673?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wagtail#diff-d2FndGFpbF9sb2NhbGl6ZS9maWVsZHMucHk=) | `92.59% <100.00%> (+1.52%)` | :arrow_up: | | [wagtail\_localize/locales/forms.py](https://codecov.io/gh/wagtail/wagtail-localize/pull/673?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wagtail#diff-d2FndGFpbF9sb2NhbGl6ZS9sb2NhbGVzL2Zvcm1zLnB5) | `100.00% <100.00%> (ø)` | | | [wagtail\_localize/locales/tests.py](https://codecov.io/gh/wagtail/wagtail-localize/pull/673?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wagtail#diff-d2FndGFpbF9sb2NhbGl6ZS9sb2NhbGVzL3Rlc3RzLnB5) | `100.00% <100.00%> (ø)` | | | [wagtail\_localize/locales/utils.py](https://codecov.io/gh/wagtail/wagtail-localize/pull/673?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wagtail#diff-d2FndGFpbF9sb2NhbGl6ZS9sb2NhbGVzL3V0aWxzLnB5) | `100.00% <100.00%> (ø)` | | | [wagtail\_localize/locales/views.py](https://codecov.io/gh/wagtail/wagtail-localize/pull/673?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wagtail#diff-d2FndGFpbF9sb2NhbGl6ZS9sb2NhbGVzL3ZpZXdzLnB5) | `93.37% <100.00%> (ø)` | | | [wagtail\_localize/locales/wagtail\_hooks.py](https://codecov.io/gh/wagtail/wagtail-localize/pull/673?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wagtail#diff-d2FndGFpbF9sb2NhbGl6ZS9sb2NhbGVzL3dhZ3RhaWxfaG9va3MucHk=) | `94.73% <100.00%> (ø)` | | | [wagtail\_localize/modeladmin/helpers.py](https://codecov.io/gh/wagtail/wagtail-localize/pull/673?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wagtail#diff-d2FndGFpbF9sb2NhbGl6ZS9tb2RlbGFkbWluL2hlbHBlcnMucHk=) | `100.00% <100.00%> (ø)` | | | ... and [19 more](https://codecov.io/gh/wagtail/wagtail-localize/pull/673?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wagtail) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wagtail). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wagtail)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

katdom13 commented 1 year ago

The latest commit https://github.com/wagtail/wagtail-localize/pull/673/commits/aa2c0c479495ac1c72a474b68519d3ebef7bc0ab updates the workflow to use tox-gh-actions as suggested by Nick Moreton. This approach eliminates the redundancy of duplicating the test configuration within the workflow, with tox.ini serving as the sole method of configuring the test matrix.