search

wagtail / wagtail-localize

Translation plugin for Wagtail CMS
https://wagtail-localize.org/
Other
222 stars 84 forks source link

WIP: Upgrade for Wagtail 5.0 #697

Closed nickmoreton closed 1 year ago

nickmoreton commented 1 year ago

This work updates the package testing and upgrade considerations for working with Wagtail v5.0

Also:

Notable changes from the upgrade considerations:

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (d0d9667) 93.09% compared to head (88d06c8) 93.09%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #697 +/- ## ======================================= Coverage 93.09% 93.09% ======================================= Files 47 47 Lines 3912 3912 Branches 581 581 ======================================= Hits 3642 3642 Misses 159 159 Partials 111 111 ``` | [Impacted Files](https://app.codecov.io/gh/wagtail/wagtail-localize/pull/697?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wagtail) | Coverage Δ | | |---|---|---| | [wagtail\_localize/wagtail\_hooks.py](https://app.codecov.io/gh/wagtail/wagtail-localize/pull/697?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wagtail#diff-d2FndGFpbF9sb2NhbGl6ZS93YWd0YWlsX2hvb2tzLnB5) | `89.86% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

nickmoreton commented 1 year ago

There's more work needed. It is worth testing such upgrades with the new Wagtail version, but they always must be tested with the supported versions (usually LTS, and whatever version is before the one you're doing the upgrade).

Thanks @zerolab How did I not think of that, I've done enough of these 🥲 I'll look again.

zerolab commented 1 year ago

Continued in #699