Closed tspnn closed 1 year ago
Hey @spikenn,
Would be good to have some screenshots -- before & after with the dark theme, and how the changes look with Wagtail 4.1
Hi @zerolab
Wagtail 4.1.6 - some CSS variables are missing Wagtail 5 (dark, before) Wagtail 5 (dark, after) Wagtail 5 (light, after)
Thank you for that, the UI does look much better in dark mode with these changes. It would be good to add the missing CSS variables for 4.1 as that is our long term support version and it would be unfair to make the experience worse
@zerolab I added fallback values, now it looks better.
That is most excellent, thank you @spikenn
Will test locally this evening and if all is good, will merge and package it all up for a release
By way of update -- this needs more work on consistency. I am chipping away slowly at it. May be a Friday release
Merged manually in b60a60056452f6e06dd588bb16411619f3cd0e0d + parents. Thank you @spikenn
v1.5.1 is now published
Codecov Report
Patch and project coverage have no change.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #701 +/- ## ======================================= Coverage 93.29% 93.29% ======================================= Files 47 47 Lines 3905 3905 Branches 579 579 ======================================= Hits 3643 3643 Misses 152 152 Partials 110 110 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.