search

wagtail / wagtail-localize

Translation plugin for Wagtail CMS
https://wagtail-localize.org/
Other
222 stars 84 forks source link

Custom Chooser not used used in translation mode #717

Open enzedonline opened 11 months ago

enzedonline commented 11 months ago

I'm using image and page choosers with the edit button removed from the chosen item ({"show_edit_link":False}), for both FieldPanels and ChooserBlocks. It's particularly causing a problem in translation mode where translation editors are choosing the edit button instead of change. They realise the mistake on the page chooser, but the image chooser often ends up with the editor uploading the locale specific image to replace the original, it's not so obvious to the editor that they are overriding the original image.

That works fine on the source page, but the translation page ignores the widget settings.

image

To me, the edit link doesn't belong on the translation page at all, but at the least, the translation page should be using the same widget and widget attributes.

The edit link can be hidden with some css as a last resort, but would be good to get consistency between source page and translation page.

zerolab commented 11 months ago

Thank you for raising this, @enzedonline. I agree we should at the very least respect the attributes.

One more case for dropping the React side of things (#715). Adding to the list.

If you do happen to have the time to look into the existing code, it would be most welcome