search

wagtail / wagtail-localize

Translation plugin for Wagtail CMS
https://wagtail-localize.org/
Other
222 stars 84 forks source link

Fix splitting of en locale codes according to DeepL requierements #739

Closed unreadableusername closed 9 months ago

unreadableusername commented 10 months ago

Added American and British English locales to translation target locale array. fixes #738

unreadableusername commented 10 months ago

I see the checks fail, but judging from the output this has nothing to do with my small change, but rather with some dev dependencies that might need a bump right? I am just anxious because this is my first contribution 🥳

zerolab commented 10 months ago

We have some Netlify jobs that fail and are on the list to be replaced. Triggered the actual CI tasks (they require approval to be run on PRs from first time contributors)

codecov-commenter commented 10 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (e1051b0) 92.65% compared to head (5a78a67) 92.65%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #739 +/- ## ======================================= Coverage 92.65% 92.65% ======================================= Files 46 46 Lines 4002 4002 Branches 596 596 ======================================= Hits 3708 3708 Misses 174 174 Partials 120 120 ``` | [Files](https://app.codecov.io/gh/wagtail/wagtail-localize/pull/739?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wagtail) | Coverage Δ | | |---|---|---| | [wagtail\_localize/machine\_translators/deepl.py](https://app.codecov.io/gh/wagtail/wagtail-localize/pull/739?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wagtail#diff-d2FndGFpbF9sb2NhbGl6ZS9tYWNoaW5lX3RyYW5zbGF0b3JzL2RlZXBsLnB5) | `66.66% <0.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

zerolab commented 9 months ago

Added tests and merged in https://github.com/wagtail/wagtail-localize/commit/a3efa8f65de3445c75ea271b1b0ee513a445deaa Thank you