search

wagtail / wagtail-localize

Translation plugin for Wagtail CMS
https://wagtail-localize.org/
Other
222 stars 84 forks source link

updating tests as .assertFormError() is removed in Django 5 #754

Closed softquantum closed 8 months ago

softquantum commented 8 months ago

I tested with tox locally and all tests passed, why is the test deployment failing ? Also when adding Django 5 in the mix the modeladmin seems to be where some tests are still faililng, I still need to figure out the logs. Any info would help :). Willing to work on this. Merry Christmas :)

zerolab commented 8 months ago

Those are Netlify errors (on the list to move away from hosting docs there) Just triggered the proper CI jobs.

Also, any chance you could fold in the changes from #747? So as to actually test with Django 5.0

codecov-commenter commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (a458ed8) 92.58% compared to head (2f54860) 92.62%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #754 +/- ## ========================================== + Coverage 92.58% 92.62% +0.03% ========================================== Files 47 47 Lines 4034 4054 +20 Branches 600 600 ========================================== + Hits 3735 3755 +20 Misses 177 177 Partials 122 122 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

softquantum commented 8 months ago

Those are Netlify errors (on the list to move away from hosting docs there) Just triggered the proper CI jobs.

Also, any chance you could fold in the changes from #747? So as to actually test with Django 5.0

I added the deps locally already and had still tests issues around modeladmin. Not sure where to look as the log is a bit weird.

zerolab commented 8 months ago

I am happy to merge this as is, and we can focus on the rest of the errors. Not sure what's happening there without looking into it, to be honest.

Will try to have a bit of a dig tomorrow morning, unless you beat me to it

softquantum commented 8 months ago

Will try to do it before ;)