search

wagtail / wagtail-localize

Translation plugin for Wagtail CMS
https://wagtail-localize.org/
Other
216 stars 83 forks source link

Add tests with success messages for locale creation, editing, and deletion #763

Closed ACK1D closed 5 months ago

ACK1D commented 6 months ago

Added tests for #762 (success messages for create, edit, and delete locale). Some logic has been refactored into BaseLocaleTestCase, and correcting some tests for use it. Please review code and let me know if need some work.

codecov-commenter commented 6 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (bb04c76) 92.64% compared to head (9690800) 92.73%. Report is 1 commits behind head on main.

Files Patch % Lines
wagtail_localize/locales/tests.py 99.15% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #763 +/- ## ========================================== + Coverage 92.64% 92.73% +0.09% ========================================== Files 47 47 Lines 4065 4130 +65 Branches 602 603 +1 ========================================== + Hits 3766 3830 +64 Misses 176 176 - Partials 123 124 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ACK1D commented 6 months ago

Hi @zerolab I've made some changes to code, and it would be helpful to update the Codecov report. Could you please trigger a new run? Thank you!

zerolab commented 6 months ago

@ACK1D thank you very much for this. I am not sure how to make Codecov update its comment, but https://app.codecov.io/gh/wagtail/wagtail-localize/pull/762 shows a +0.11% increase