search

wagtail / wagtail-localize

Translation plugin for Wagtail CMS
https://wagtail-localize.org/
Other
216 stars 83 forks source link

Add formality support to DeepL translator #779

Closed Abdul-Dridi closed 4 months ago

Abdul-Dridi commented 5 months ago

This PR adds formality support to the existing DeepL translator (https://www.deepl.com/docs-api/translate-text). This is done by specifying an optional option.

codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (bf5f896) 92.80% compared to head (0f5c463) 92.85%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #779 +/- ## ========================================== + Coverage 92.80% 92.85% +0.05% ========================================== Files 47 47 Lines 4112 4115 +3 Branches 599 600 +1 ========================================== + Hits 3816 3821 +5 + Misses 177 175 -2 Partials 119 119 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Abdul-Dridi commented 4 months ago

@zerolab Any chance I could request a review on this? 🙏

Abdul-Dridi commented 4 months ago

Good for another review 👍

zerolab commented 4 months ago

Thanks. Tidied up and merged in cf12512