search

wagtail / wagtail-newsletter

Send email newsletters based on Wagtail content
https://wagtail-newsletter.readthedocs.io
BSD 3-Clause "New" or "Revised" License
9 stars 3 forks source link

Send campaign #37

Closed mgax closed 1 week ago

mgax commented 2 weeks ago

Fixes https://github.com/wagtail/wagtail-newsletter/issues/24. Fixes https://github.com/wagtail/wagtail-newsletter/issues/25.

olivierphi commented 2 weeks ago

I started to test the branch on my local environment, and overall it seems to work pretty well :+1:

I really like the spinner that is started just before the form is submitted, as it gives a much better user experience to the editor while the communication with Mailchimp takes place :slightly_smiling_face:

I have 2 questions, that are not related to that specific PR but it seems that we're getting closer to being able to use that package for real now so I thought it could be worth testing a bit more thoroughly:

Screenshot of Merge Tags displayed as italic text in the received email:

Screenshot from 2024-06-18 16-39-53

mgax commented 1 week ago

I really like the spinner that is started just before the form is submitted, as it gives a much better user experience to the editor while the communication with Mailchimp takes place 🙂

Thank you! Yeah, I think we have the opportunity to provide a nice user experience, and it's nice to have a slick interface 🙂

I have 2 questions, that are not related to that specific PR but it seems that we're getting closer to being able to use that package for real now so I thought it could be worth testing a bit more thoroughly:

  • As Mailchimp "Merge Tags" use the *|TAGNAME|* form, if we try to use them in a Wagtail richtext they seem to be converted to italic text by Wagtail - which looks to be interpreting the content as Markdown? This prevents the use of Merge Tags 😔

Huh, you raise a good point, I hadn't realised this. I've opened an issue: https://github.com/wagtail/wagtail-newsletter/issues/39.

  • On a side note: if I create a copy of a Wagtail Page, this copy seems to share the same Campaign as the original Page - and if the original Page was already sent as a newsletter campaign, the copy will also be considered as sent. Is this the expected behaviour?

No, I don't think so. Since this was introduced in a former PR, and I'd rather get this one merged, I've opened another issue: https://github.com/wagtail/wagtail-newsletter/issues/40.