Closed vossisboss closed 1 year ago
Hi, @vossisboss i'll be taking up on these. Hoping to send a good report soon
Thank you for giving this a go @fyunusa. Do let us know if you have any questions.
Hi @vossisboss , i have been able to remove the blocks from blogPage and added the blocks needed from contentPage.
First The the BlogStoryBlock inherits from the utils storyBlock and extends it with a method for the standalone_cta block, which makes up the current BlogStoryBlock , using same approach i was able to extend the BlogStoryBlock with new Blocks needed:
Secondly Due to the BlogStoryBlock inherits from the utils StoryBlock with my little knowledge of the system
The current codebase shows that these blocks are to be removed from the utils StoryBlocks
imagecaption = ImageAndCaptionBlock(label="Image caption") # to be removed
colourtext = BackgroundColourTextBlock(icon="pilcrow") # to be removed
calltoaction = CallToActionBlock(icon="pilcrow") # to be removed
tripleimage = TripleImageBlock(icon="image") # to be removed
stats = ListBlock(StatBlock(icon="code")) # to be removed
These blocks don't indicate to be removed and might affect other components using them if we have to remove them from the utils StoryBlock
@fyunusa I think those blocks weren't labeled as # to be removed
because they got missed when we were evaluating which blocks to keep and which ones to remove. I'm aware that removing them might affect other components but since we aren't planning to use them again, I think it is worth trying to remove them from StoryBlock
. Please go ahead and trying removing them.
Does that provide the clarity that you need to proceed?
ok, yeah thank you @vossisboss clarified already
There are two main things that need to happen for this issue to be addressed. First, old block types that we are no longer using anymore need to be removed from the StreamField for
BlogPage
so that people won't use them anymore. Second, certain blocks fromContentPage
need to be added toBlogPage
so people can use them in their blogs as well.The following blocks need to be removed from
BlogPage
so that people don't use them anymore:The following blocks from
ContentPage
need to be available inBlogPage
:When these blocks are added to
BlogPage
, we'll need to confirm that they display appropriately with the frontend styles used forBlogPage
.