wagtail / wagtail.org

Wagtail’s official marketing website
https://wagtail.org/
66 stars 60 forks source link

Roadmap page #379

Closed laymonage closed 1 year ago

laymonage commented 1 year ago

How to run

Notes

We should think about how the access token should be created for production.

The most proper way to do this would be to create a GitHub App under the Wagtail organisation, and then authenticate as the app. However, this is much more complicated as we'll need to:

Alternatively, the much easier way would be to use someone's account (or an empty account) to generate a personal access token without any access, which I've done here.

EDIT: Now that fine-grained access tokens can be used on the GraphQL API, we can create an access token with the Wagtail organisation as the owner, and with read-only access to public repositories (without any permissions configured).

laymonage commented 1 year ago

@thibaudcolas I've made adjustments per your review:

laymonage commented 1 year ago

All looking great! Only thing I’d have suggested doing differently is to combine the migrations so it looks neater, but doesn’t really matter for a project of this size.

Thanks! I considered doing that but I thought it would make it harder for you to do another review as you’d need to make sure it could be run locally after the initial migration 😅