search

wagtail / wagtail.org

Wagtail’s official marketing website
https://wagtail.org/
66 stars 60 forks source link

Fixed Text Disappearing issue in footer light mode. Fix #405 #417

Closed MugoBrian closed 1 year ago

MugoBrian commented 1 year ago

Fixed text disappearing issue in the footer in light mode. This PR fix is for issue #405. Tested the changes on:

OS: Ubuntu 22.0.4 Browser: Google Chrome Version 117.0.5938.149 (Official Build) (64-bit)

MugoBrian commented 1 year ago

Thank you for giving this a go @MugoBrian! I like this approach but I think there’s some more room for improvement because on the heading we define:

    transition: color .3s;

With your proposed changes, this creates a strange situation where the heading and context text change colors at different speeds.

Could you tweak this more, either remove transition: color .3s; or move it to apply to footer__icon-link-content like you’ve done for the color change?

Ok, let me have a look at it. Ah, that's why there's a 'jumping effect' behavior in the content paragraph when there's a 'mouseout' event. Screencast from 09-10-2023 04:45:43 ALASIRI.webm

MugoBrian commented 1 year ago

I have updated the transition 0.3 property on the footer. Kindly review it @thibaudcolas