Adding LoopingVideoBlock to ContentPage

wagtail / wagtail.org

Wagtail’s official marketing website

https://wagtail.org/

66 stars 60 forks source link

Adding LoopingVideoBlock to ContentPage #442

Closed vossisboss closed 10 months ago

vossisboss commented 10 months ago

Currently, we do have the ability to add videos to the ContentPage type and we need to be able to add the occasional demo video. In this PR, I have:

Added LoopingVideoBlock() to ContentStoryBlock()
Removed autoplay from LoopingVideoBlock to reduce the emissions impact of autoplay videos and discourage their use
Updated the associated migrations

Please let me know if there are any changes that could make this a bit more DRY.

vossisboss commented 10 months ago

@zerolab Ready for another check. When I ran the make migrations command, there were no automatically generated migration files despite switching the name of the block. Is this typical? Makes me wonder if I'm doing something wrong.

zerolab commented 10 months ago

@zerolab Ready for another check. When I ran the make migrations command, there were no automatically generated migration files despite switching the name of the block. Is this typical? Makes me wonder if I'm doing something wrong.

Not at all. the video block is a custom StructBlock and that is defined as such in the migration: https://github.com/wagtail/wagtail.org/pull/442/files#diff-bd1d2fc245b73f85af268ecb5a151b6663730e0264ebd3fd17a9e26901bc18fcR1048-R1064 - it doesn't really care how we call it