Closed shyusu4 closed 6 months ago
Fixed instances (in hero, headline, and icon-link blocks) where headings were used consecutively after one another.
I looked for an issue in the audit spreadsheet that this addresses but couldn't easily find one. Could you point it out for me?
I'm a bit concerned about the addition of hgroup
elements. They're probably harmless in the short term, but according to MDN, they have been removed from the HTML spec and are discouraged from being used. If a wrapper is helpful for applying the role="group" aria-roledescription="heading group"
attributes, a div
is probably best in this case.
This PR addresses accessibility issues related to heading levels and forms:
h2
457
459
aria-label="Email"
instead of<label>
fieldset
in search-form to adiv
(fieldset is used to group multiple form fields together, but there's only one here)Screenshots
| before | after | | --- | --- | |![Screenshot (109)](https://github.com/wagtail/wagtail.org/assets/106587342/fc15bf10-9c86-4492-b8e9-8be0b6bdd35c)|![Screenshot (105)](https://github.com/wagtail/wagtail.org/assets/106587342/76857a70-8971-4364-83f0-186e50071d49)| ![Screenshot (110)](https://github.com/wagtail/wagtail.org/assets/106587342/049f521b-a199-4f15-8084-06c4157334e0)|![Screenshot (106)](https://github.com/wagtail/wagtail.org/assets/106587342/10d14cef-ff53-402a-bcc0-52f204713c5b)|