Open benenright opened 1 year ago
@benenright @thibaudcolas I will start working on a PR to solve this.
Increase space between primary label and child field label
By how much should I increase it ?
Increase top/bottom padding a bit in block-chooser buttons
By how much should I increase ?
Thanks
Hi, thats great!
Increase space between primary label and child field label By how much should I increase it ?
I suggest 1.5 rem - see screenshot. I suspect this is the incorrect element to add the extra bottom-margin too though, as it will cause the margin elsewhere to become too big.
For example, here the same element is used as a streamfield title, with the '+' below it, so we wouldn't need to increase it;'s bottom margin here:
And the same here:
And here: (we dont want to push help text away from it)
So perhaps in the instance I have flagged we need to find a custom way to increase the space:
And this one:
Increase top/bottom padding a bit in block-chooser buttons By how much should I increase ?
I would increase to 0.5rem padding (top, right, bottom and left):
And this one:
Increase top/bottom padding a bit in block-chooser buttons By how much should I increase ?
I would increase to 0.5rem padding (top, right, bottom and left):
Thanks @benenright , very helpful
Hello @benenright Please check out my pull request if it solves the initial set of issues created?
Planning on preparing another PR to address the next issues once that has been merged since I don't think it would be great to have all in one PR
Partial progress on this has been merged via #11097
I see we fixed the space here between the section title and first field title on the account page (as mentioned above):
But we still have this problem elsewhere eg in the promote tab (under 'For search engines' and 'For site menus') and poss elsewhere? :
@helenb could you investigate this?
Here I am collating various stying updates/issues. Hopefully one day a kind soul can whizz through these.
See design:
...So that it appears more like this to the right of the '+' :
Vertically align trigger button with search field within the flyout menu
...it is still present in the unpinned toolbar actually: So I suggest we mimick the same style in the white pinned version - use a sublter border and a light grey background
Build:
Design:
Issue with space to the side of the 'pin' button on the unpinned toolbar:
Build:
Design update: