gasman
commented
7 years ago Have been looking into what it would take to allow AdminPageChooser to be used on pages outside the page editor, without importing all of _editor_js.html, and it seems like it's going to be more involved than just shuffling some import lines around...
AdminPageChooser requires the following JS code to work:
- the (dynamic) snippet that sets up window.chooserUrls
- modal-workflow.js
- page-chooser.js
We could easily split these off into a new _page_chooser_js.html include, included from _editor_js.html and any other templates that require AdminPageChooser. However, this is going to lead us down a path of messy dependency tracking: a page that includes _page_chooser_js.html has to know not to import modal-workflow.js itself. And if we do the same decoupling exercise on another component, such as the image chooser, there's no way to include both of them without importing modal-workflow.js twice.
To make this work, then, we'll need a helper that keeps track of the JS imports that are already present, and de-duplicates them - something like Django's form media, but globally for the template, and able to handle arbitrary snippets such as the one for window.chooserUrls, not just <script> file imports. Perhaps the building block would be a template tag like:
{% includeonce chooser_urls %}
<script>
window.chooserUrls = {...};
</script>
{% endincludeonce %}
{% includeonce modal_workflow %}
<script src="{% static 'modal-workflow.js' %}"></script>
{% endincludeonce %}
thibaudcolas
lb-
wagtailadmin/pages/_editor_js.htmlwas only ever meant to be used on the page add/edit views, but is currently imported in various templates throughout Wagtail admin because it's a convenient grab-bag of JS functions that saves the effort of actually thinking about what JS you're using. Some of the code there is generally reusable (e.g. page chooser modals) and some of it is relevant to other edit-handler-based interfaces (snippets, settings) but a lot of it is only specific to the page editor (e.g. setting up behaviour for the slug field and preview button). We really ought to refactor these templates so that they only import and run the JS that's actually meaningful to each page.