wahabmirjan / wp-simple-nonce

A very simple NONCE for WordPress developers.
GNU General Public License v2.0
38 stars 11 forks source link

Clear Nonces does not clear expired nonces #7

Closed krispy1298 closed 2 years ago

krispy1298 commented 4 years ago

https://github.com/wahabmirjan/wp-simple-nonce/blob/master/WPSimpleNonce.php#L108

Shouldn't the option_value>time()+86400 be option_value<time()+86400 or option_value<time()?

phl43 commented 4 years ago

Yes, if I understand correctly this method is called once a day to clear expired nonces, so presumably the condition should be $singleNonce->option_value < time(). Unless we are mistaken, this seems like a pretty serious bug. @calevans, if you are still around, could you please tell us what you think?

wahabmirjan commented 2 years ago

Resolved. Will be released in v1.4

wahabmirjan commented 2 years ago

Reopening. Realised that expiration time is incorrectly calculated.

wahabmirjan commented 2 years ago

Resolved