wahaha303 / ICCPlus

MIT License
7 stars 4 forks source link

Non-zero hidden rows height #13

Closed DragonsWho closed 3 months ago

DragonsWho commented 3 months ago

I already wrote about this on reddit, but I'll copy it here so it doesn't get lost in the chat room

Ufff.... Damn, I guessed about this bug, but I didn't think it would be that serious in this project....

hidden Row has a non-zero height for some reason. And it looks like it's a dozen centimeters in my current project.... >_< Dragons_Whore 3:08 AM Hooray! By some miracle I overcame it! At some point, the application loads additional css at https://maxcdn.bootstrapcdn.com/bootstrap/scss/mixins/_grid-framework.scss and there's a segment

@mixin make-grid-columns($columns: $grid-columns, $gutter: $grid-gutter-width, $breakpoints: $grid-breakpoints) { // Common properties for all breakpoints %grid-column { position: relative; width: 100%; min-height: 1px; // Prevent columns from collapsing when empty padding-right: ($gutter / 2); padding-left: ($gutter / 2); } Read more !!! min-height: 1px; // Prevent columns from collapsing when empty !!! Damn bastards, why did they have to assign a minimum height to a hidden element?!! For some reason this rule literally overrides "display: none;" and.... here's my solution >_>

I'm 250% sure it's monstrously redundant and wrong. but if this is inserted at the very bottom of the the problem disappears Anyway, I found a temporary solution, but I really hope you can do it more properly >_>

wahaha303 commented 3 months ago

It have fixed 1.4.0