Hello Group 9. Below is my feedback for Milestone 2. Please note that the mark posted here may change on an individual basis if it is found that certain group members did not contribute in an equal capacity. Feel free to close this issue at any point.
Overall Mark: 10/10
Demo Notes:
Fantastic work all around. Your bookstore app is coming along very well and you have a large set of features completed and working! Keep up the great work
Repo Notes:
Your process side looks good! Excellent work on your PRs, issues, and keeping up with your Kanban.
Your UML Class Diagram has a few issues in regard to relationships. As an example, Book and Author should be a two-way relationship since each class has a list of the other type as a field (so it should have a diamond on both sides of the relationship). Further, using composition everywhere is a bit much, some of the relationships could be downgraded to aggregations or even associations (for example Item has a field of Book, but is not contained within a List, this should just be an association relationship). Keep these things in mind going forward. I won't take marks off for this but if this isn't fixed for the next milestone I will.
Your tests are good. Everyone appears to be taking part in writing tests and you've covered a lot of your existing functionality. As mentioned the switch to a single version of Junit appears to have fixed the CI problems that were being experienced so be sure to keep that in mind if the problem pops up again in the future.
Hello Group 9. Below is my feedback for Milestone 2. Please note that the mark posted here may change on an individual basis if it is found that certain group members did not contribute in an equal capacity. Feel free to close this issue at any point.
Overall Mark: 10/10
Demo Notes:
Repo Notes: