cqueues.h: correctly declare a variable

wahern / cqueues

Continuation Queues: Embeddable asynchronous networking, threading, and notification framework for Lua on Unix.

http://25thandclement.com/~william/projects/cqueues.html

MIT License

244 stars 37 forks source link

cqueues.h: correctly declare a variable #233

Closed vcunat closed 4 years ago

vcunat commented 4 years ago

Otherwise it gets a definition in every *.c file it gets included into.

I'm not sure why these errors never caused problems (AFAIK) until recent Fedora Rawhide. https://kojipkgs.fedoraproject.org//work/tasks/420/41320420/build.log

vcunat commented 4 years ago

On a different distro using gcc10 isn't sufficient to trigger this error (or even a warning), so the practical consequences of missing extern clearly aren't as simple as I originally thought.

vcunat commented 4 years ago

ping @wahern

vcunat commented 4 years ago

I meant, ping @daurnimator :-)

daurnimator commented 4 years ago

I think this is correct but I'm not 100% sure. Would love for you @wahern to confirm...