wahn / rs_pbrt

Rust crate to implement a counterpart to the PBRT book's (3rd edition) C++ code. See also https://www.rs-pbrt.org/about ...
https://www.rs-pbrt.org
Other
811 stars 59 forks source link

rendering job terminated by signal SIGKILL #143

Closed w3ntao closed 1 year ago

w3ntao commented 1 year ago

When rendering ganesha (or sss_dragon), I got the error:

fish: Job 1, 'absolute_path/rs_pbrt…' terminated by signal SIGKILL (Forced quit)

full command:

$ tar zxfv pbrt_ganesha.tar.gz
$ cd pbrt_ganesha/
$ /absolute_path/rs_pbrt/target/release/rs_pbrt  --path=ganesha.pbrt
rs_pbrt version 0.9.9 (unknown) [Detected 12 cores]

Copyright (c) 2016-2023 Jan Douglas Bert Walter.
Rust code based on C++ code by Matt Pharr, Greg Humphreys, and Wenzel Jakob.

Integrator "path"
  "integer maxdepth" [4]
Sampler "halton"
  "integer pixelsamples" [16]
Film "rgb"
  "string filename" ["ganesha.png"]
  "integer xresolution" [720]
  "integer yresolution" [720]
fish: Job 1, 'absolute_path/rs_pbrt…' terminated by signal SIGKILL (Forced quit)
wahn commented 1 year ago

Strange, I'm just rendering the latest version on my MacBook Pro and it works:

% ~/git/sourcehut/rs-pbrt/target/release/rs_pbrt --path ganesha.pbrt
rs_pbrt version 0.9.9 (unknown) [Detected 8 cores]

Copyright (c) 2016-2023 Jan Douglas Bert Walter.
Rust code based on C++ code by Matt Pharr, Greg Humphreys, and Wenzel Jakob.

Integrator "path"
  "integer maxdepth" [4]
Sampler "halton"
  "integer pixelsamples" [512]
Film "image"
  "string filename" ["ganesha.exr"]
  "integer xresolution" [720]
  "integer yresolution" [720]
Integrator "path"
Rendering with 8 thread(s) ...
2116 / 2116 [=====================================================] 100.00 % 4.78/s 
Writing image "pbrt.png" with bounds Bounds2i { p_min: Point2i { x: 0, y: 0 }, p_max: Point2i { x: 720, y: 720 } }

Let's see if the = sign you use in your command line makes a difference:

% ~/git/sourcehut/rs-pbrt/target/release/rs_pbrt --path=ganesha.pbrt

Seems to work as well ...

What happens if you use a space ( ) instead?

Can it be a problem of the fish shell?

% fish
Welcome to fish, the friendly interactive shell
Type help for instructions on how to use fish
jan@Jans-MacBook-Pro ~/g/g/r/p/pbrt_ganesha (master)> ~/git/sourcehut/rs-pbrt/target/release/rs_pbrt --path=ganesha.pbrt
rs_pbrt version 0.9.9 (unknown) [Detected 8 cores]

Copyright (c) 2016-2023 Jan Douglas Bert Walter.
Rust code based on C++ code by Matt Pharr, Greg Humphreys, and Wenzel Jakob.

Integrator "path"
  "integer maxdepth" [4]
Sampler "halton"
  "integer pixelsamples" [512]
Film "image"
  "string filename" ["ganesha.exr"]
  "integer xresolution" [720]
  "integer yresolution" [720]
Integrator "path"
Rendering with 8 thread(s) ...
...

No, seems to work as well ...

Which operating system are you using?

I'm using the latest commit of the master branch:

% pwd
/Users/jan/git/sourcehut/rs-pbrt
% git log | head -n 1
commit a757321667fa480c75e6e45e5d11e11837ba7c0a
wahn commented 1 year ago

BTW, you can use something like this in your bash shell to compile the last commit tag into your executable:

% bash
% git describe --tags
v0.9.9-9-ga757321
% export GIT_DESCRIBE=v0.9.9-9-ga757321
% make
...
% ./target/release/rs_pbrt --help
rs_pbrt version 0.9.9 (v0.9.9-9-ga757321) [Detected 8 cores]
...
w3ntao commented 1 year ago

I was testing with WSL-Ubuntu (Kernel: 5.15.90.1-microsoft-standard-WSL2).

The weird thing is, I can't reproduce the error again, either for the latest version or the last version that triggered the error (52a11f8baf3338ddbd623cec00abbd41911cc931).

Anyway it's working now. Issue closed.