search

wailsapp / wails

Create beautiful applications using Go
https://wails.io
MIT License
25.34k stars 1.22k forks source link

Vuetify 2.1.0 #287

Closed ljjimenez closed 4 years ago

ljjimenez commented 5 years ago

Description

Upgrade to Vuetify 2.1.0, is it possible?

I would like to migrate a web app to desktop, but using Vuetify 2.1.0.

bh90210 commented 5 years ago

hi @ljjimenez I am sure it is possible! I am looking into vuetify and seems there are many ways to approach it. from the point of view of Wails though, what u need to do is:

  1. Make sure you load all images, fonts etc like this https://github.com/wailsapp/wails/blob/daeda501f448cb3896f07d1716c7c7daf662c2ef/cmd/templates/vuetify-basic/frontend/vue.config.js#L13
  2. make sure to only produce one .js file https://github.com/wailsapp/wails/blob/daeda501f448cb3896f07d1716c7c7daf662c2ef/cmd/templates/vuetify-basic/frontend/vue.config.js#L31
  3. and finnaly make sure to only produce one .css file https://github.com/wailsapp/wails/blob/daeda501f448cb3896f07d1716c7c7daf662c2ef/cmd/templates/vuetify-basic/frontend/vue.config.js#L4

if need help please share your repo (if not private) so we can take a look at your code :)

leaanthony commented 5 years ago

Hi. We had a ticket for this. I don't think Michael responded for quite a while so it went stale. If you are able to pick this up and make a PR, we will look at it :+1:

lyimmi commented 4 years ago

One of my project is made with vuetify 2.x, but it does not work on windows (MSHTML/Webview isse). I have a few ideas how to make it work, but didn't have any motivation to do so.

I can make a PR, based on that project, if needed. In the ticket that @leaanthony mentioned there are two alternatives, I would go with the second one to make two separate Vuetify templates.

But if you guys think it's ok to update the existing one, than I can do that too.

bh90210 commented 4 years ago

hey @Lyimmi amazing! A new Vue 2.x template sounds fine.

Let's ask @MichaelHipp (https://github.com/MichaelHipp/wails/tree/vuetify2-support) if he has made any progress, to possibly avoid double coding the same thing..

leaanthony commented 4 years ago

A PR would be awesome! I'd go for just updating the current template if everyone is upgrading. But if it's kinda like Python then maybe a new template?

On Thu, 21 Nov 2019, 18:30 Zámbó, Levente, notifications@github.com wrote:

One of my projects is made with vuetify 2.x, but it does not work on windows (MSHTML/Webview isse). I have a few ideas how to make it work, but didn't have any motivation to do so.

I can make a PR, based on that project, if needed. In the ticket that @leaanthony https://github.com/leaanthony mentioned there are two alternatives, I would go with the second one to make two separate Vuetify templates.

But if you guys think it's ok to update the existing one is good for me too.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/wailsapp/wails/issues/287?email_source=notifications&email_token=AAO2SYDO4INV2WDKL4Q3BHTQUY2KDA5CNFSM4JLXGCCKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEZH5NA#issuecomment-556957364, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAO2SYGIAJWPZ2D5IOYZKWDQUY2KDANCNFSM4JLXGCCA .

MichaelHipp commented 4 years ago

I haven't looked at it since 10/2 when I was told we were going into a feature freeze for v1.0. I still have it and doubt 2.1 would be much different than 2.0.

leaanthony commented 4 years ago

Hey @MichaelHipp. Looking through the comments on the ticket, it looked like you were still working on it. Is the PR good?

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.