mrf345 commented 2 months ago

Description

Fix the missing drag and drop cursor icon for prod runtime, this's a follow-up to #3703

Fixes #3702

Type of change

Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested locally, after the fix:

drag_and_drop_cursor_after

[ ] Windows
[ ] macOS
[x] Linux

Test Configuration

# Wails
Version         | v2.9.1
Package Manager | pacman

# System
┌──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┐
| OS           | Arch Linux                                                                                                        |
| Version      | Unknown                                                                                                           |
| ID           | arch                                                                                                              |
| Go Version   | go1.23.0                                                                                                          |
| Platform     | linux                                                                                                             |
| Architecture | amd64                                                                                                             |
| CPU          | AMD Ryzen 7 4800H with Radeon Graphics                                                                            |
| GPU 1        | Navi 14 [Radeon RX 5500/5500M / Pro 5500M] (Advanced Micro Devices, Inc. [AMD/ATI]) - Driver: amdgpu              |
| GPU 2        | Renoir [Radeon Vega Series / Radeon Vega Mobile Series] (Advanced Micro Devices, Inc. [AMD/ATI]) - Driver: amdgpu |
| Memory       | 15GB                                                                                                              |
└──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┘

# Dependencies
┌───────────────────────────────────────────────────────────────────┐
| Dependency | Package Name | Status    | Version                   |
| *docker    | docker       | Installed | 1:27.1.1-1                |
| gcc        | gcc          | Installed | 14.2.1+r32+geccf707e5ce-1 |
| libgtk-3   | gtk3         | Installed | 1:3.24.43-1               |
| libwebkit  | webkit2gtk   | Installed | 2.44.3-3                  |
| npm        | npm          | Installed | 10.8.2-1                  |
| pkg-config | pkgconf      | Installed | 2.1.1-1                   |
└───────────────────── * - Optional Dependency ─────────────────────┘

Checklist:

[x] I have updated website/src/pages/changelog.mdx with details of this PR
[x] My code follows the general coding style of this project
[x] I have performed a self-review of my own code
[ ] ~I have commented my code, particularly in hard-to-understand areas~
[ ] ~I have made corresponding changes to the documentation~
[x] My changes generate no new warnings
[ ] ~I have added tests that prove my fix is effective or that my feature works~
[x] New and existing unit tests pass locally with my changes

Summary by CodeRabbit

New Features
- Improved drag-and-drop functionality with enhanced visual feedback.
Bug Fixes
- Resolved missing cursor icon issue for production builds related to drag-and-drop operations.
Documentation
- Updated changelog to clarify fixes for different build types.

coderabbitai[bot] commented 2 months ago

Walkthrough

The changes involve significant updates to the JavaScript code in the Wails framework, focusing on event handling and drag-and-drop functionality. A variable renaming enhances clarity, while callback management is improved through optional chaining. Additionally, the drag-and-drop feature now correctly displays the cursor icon, addressing a specific user-reported issue.

Changes

File	Change Summary
v2/internal/frontend/runtime/runtime_prod_desktop.js	Replaced variable `w` with `d` for event listener management; updated callback functions to use optional chaining; refined drag-and-drop functionality for improved user feedback.
website/src/pages/changelog.mdx	Added a changelog entry for the fix regarding the missing cursor icon in drag-and-drop functionality.

Assessment against linked issues

Objective	Addressed	Explanation
Drag and drop missing cursor icon (3702)	✅

🐇 "In the garden, I hop with glee,
A cursor's back, as bright as can be!
With events now clear, and drags so fine,
Wails shines bright, a framework divine!"
🌼

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.