search

wailuen / homebridge-sensibo-sky

Homebridge Sensibo Sky
33 stars 25 forks source link

fixing fahrenheit logic #36

Closed imerin closed 4 years ago

imerin commented 5 years ago

This should fix these issues:

Sensibo setting target to 100F on startup

Sensibo always setting temperature unit to celsius

DarylMc commented 5 years ago

@imerin Thanks for the work you have put in there.

luissimoes commented 5 years ago

sorry for the simple question but how do I use the latest changes? as mentioned in a new issei's Weiluen seems to have disappeared and there isn't a new "package" (main).... but there was this excellent work from @imerin .... so, how can we use this?

imerin commented 5 years ago

@luissimoes you can clone my forked repo and then overwrite the homebridge-sensibo-sky directory in your node_modules folder with the contents of the cloned repo.

luissimoes commented 5 years ago

@luissimoes you can clone my forked repo and then overwrite the homebridge-sensibo-sky directory in your node_modules folder with the contents of the cloned repo.

@imerin cheers!!! so basically I should copy the files in accessories and lib folders and overwrite the corresponding files in my Raspberry installation of the Homebridge Plugin?

image

imerin commented 5 years ago

@luissimoes Yes, I made changes to index.js as well but they are not necessary to get the improved functionality.

Let me know how it goes for you.