search

wainuiomata / sambal

Experimental web admin for Samba and Active Directory domains
https://wainuiomata.com
GNU General Public License v3.0
1 stars 1 forks source link

Use ruff for linting #20

Closed robvdl closed 8 months ago

robvdl commented 8 months ago

For the time being I'm holiding off switching to ruff due to this bug:

https://github.com/astral-sh/ruff/issues/10253

In the mean time I'll keep using flake8 + flake8-black + flake8-isort as usual, because we still need linting in CI.

robvdl commented 8 months ago

It seems ruff REQUIRES the use of __all__ in __init__.py EVEN IF YOU USE THE IMPORT.

I'm not sure I agree with this at all, if it's used, it's used. period. It shouldn't trigger an unused import warning.

I might do the __all__ thing anyway and not give up too soon. But I can't disagree more with the response.

robvdl commented 8 months ago

already done