search

wainuiomata / sambal

Experimental web admin for Samba and Active Directory domains
https://wainuiomata.com
GNU General Public License v3.0
1 stars 1 forks source link

Waiting on Samba MR 3548 to land #47

Closed robvdl closed 8 months ago

robvdl commented 8 months ago

Right now this branch is needed:

https://gitlab.com/samba-team/samba/-/merge_requests/3548

Keeping this ticket open until this lands in Samba master.

Reminder to update the Wiki as well when that gets merged, I think there is a note there about it needing to run of a branch.

robvdl commented 8 months ago

The location of the models has changed in this MR from samba.netcmd.domain.models to samba.domain.models so I can't wait for this to land.

Also it introduces the basic Container model. There are other types of containers too but those can be added later.

robvdl commented 8 months ago

All I have to do to get that to land now is write one additional test that does some SDDL update.

And I need docs (manpage update), the code review hasn't picked up on that yet. But it's already been provisionally approved anyway by two reviewers pending the additional test.

robvdl commented 8 months ago

It has been merged to Samba master.