waitLess-project / WaitLESS-frontend

Application for waiter-free food orders for restaurants. Hackathon Challenge
2 stars 2 forks source link

Created 404 Page, Restructuring, updated routers #10

Closed xchrisbradley closed 3 years ago

xchrisbradley commented 3 years ago

Created 404 Page:

Restructuring:

Routes:

Removed the test file and created a tests folder where once test begin, they are more structured.

Removed the webvitals, thinking of adding that to the index file as well as some other handy functionality.

Notes:

xchrisbradley commented 3 years ago

The background got changed to white on the homepage, this is temporary until I move the other components into their right folders.

If you want me to fix it now before completing the PR just lmk.

leplerjacob commented 3 years ago

Thanks @bradleycm . I am taking a look now...seems good so far. I did prefer functional. But I think we can stick to class based since that is what you're used to. It would be a learning experience for me since I haven't use React Component much. Thank you

leplerjacob commented 3 years ago

@bradleycm I see. So eventually we'd move the components over to shared in modules, or to layout folder. I am not too sure what is meant by layout. But I'll look this up.

xchrisbradley commented 3 years ago

Yea with angular it's more strict, using react is basically free form and up to you.

I suggested this approach as I didn't see one already in place, maybe we can create a docs folder and add a CONTRIBUTING.md that outlines the structure of the project as well as best practices i.e (should we use functional components or the class-based components)