waiting-for-dev / front_matter_parser

Ruby library to parse files or strings with a front matter. It has automatic syntax detection.
MIT License
105 stars 12 forks source link

Rename whitelist to allowlist #10

Closed cartogram closed 3 years ago

cartogram commented 4 years ago

I was using this gem on a project recently and the whitelist term was flagged as being a non-inclusive term, this PR renames the whitelist_classes param to allowlist_classes.

I'd be open to feedback of a better way to depreciate gradually, rather than a straight rename, as this would also prevent the Major version bump.

waiting-for-dev commented 4 years ago

Thanks @cartogram . I support this change. I'll merge it and take the occasion to release the first 1.0 version. Yeah, maybe it'd be better to add a deprecate warning for some time.

waiting-for-dev commented 3 years ago

Sorry for having taken such a long time before merging it. It's now available on version 1.0.