search

waiting-for-dev / warden-jwt_auth

JWT token authentication with warden
MIT License
113 stars 56 forks source link

feat: use Zeitwerk to load gem structure #46

Closed seuros closed 1 year ago

seuros commented 1 year ago

dry-rb use zeitwerk as loader starting from version 1.0.0

I leveraged it usage to make it work in this gem.

waiting-for-dev commented 1 year ago

Thanks, I'll look into it as soon as possible.

thomasdarde commented 1 year ago

This branch works nice for us in case it helps merging it

dmitry commented 1 year ago

@waiting-for-dev please let us know if it's still required some work for this PR.

waiting-for-dev commented 1 year ago

Many thanks for your collaboration. TBH, I don't feel comfortable adding Zeitwerk as a dependency. I know it's already transitive through dry-*, but I don't think adding the complexity here pays off. WDYT?

(I'm ok relaxing dry-* requirements, though, I already commented in the referenced PR)

seuros commented 1 year ago

@waiting-for-dev , I did notice a slight performance speed in testing by bumping to dry 1.0. (classes are loaded only when needed) This is the reason I think we should start encouraging other devs to keep their dependencies up to date.

waiting-for-dev commented 1 year ago

To be clear, I'm ok bumping to dry 1.0 (not only ok, we need to do it), but I'm not sure about using Zeitwerk here.

thomasdarde commented 1 year ago

Hi @waiting-for-dev , do you have any news on this 1.0 release schedule ?

waiting-for-dev commented 1 year ago

Hi @waiting-for-dev , do you have any news on this 1.0 release schedule ?

I just released warden-jwt_auth v0.8.0 🥳

I'll close this PR for now, but I might reconsider it in the future. Thanks again for your contribution.