waitingsong / node-win32-api

win32 api
MIT License
430 stars 55 forks source link

Add support for IsIconic and SetWindowPos #39

Closed lanzkron closed 2 years ago

lanzkron commented 2 years ago

This is an initial attempt to support IsIconic and SetWindowPos.

I did it blindly since I wasn't able to get the unit tests to run properly (even before my changes).

I also added constants similar to CmdShow is this the intended way? I don't see it used in any of the demos.

waitingsong commented 2 years ago

Run commands below at project root for lint fix:

npm run bootstrap
npm run lint

then git commit and push. or edit manually:

 /__w/node-win32-api/node-win32-api/packages/win32-api/src/lib/user32/api.ts
Error:   164:1  error  This line has a length of 130. Maximum allowed is 120  max-len

/__w/node-win32-api/node-win32-api/packages/win32-api/test/user32/63.IsIconic.test.ts
Warning:    2:1   warning  There should be at least one empty line between import groups                 import/order
Warning:    3:23  warning  A space is required before '}'                                                object-curly-spacing
Warning:    3:52  warning  Extra semicolon                                                               @typescript-eslint/semi
Warning:    4:1   warning  There should be at least one empty line between import groups                 import/order
Warning:    6:1   warning  There should be no empty line within import group                             import/order
Warning:    8:1   warning  Expected 2 empty lines after import statement not followed by another import  import/newline-after-import
Warning:   11:6   warning  Strings must use singlequote                                                  quotes
Warning:   12:25  warning  Strings must use singlequote                                                  quotes
waitingsong commented 2 years ago

Thanks for your contribution