search

waitingsong / node-win32-api

win32 api
MIT License
430 stars 55 forks source link

Added PeekMessage #4

Closed TheNoim closed 6 years ago

dunklesToast commented 6 years ago

Looks good. Also need this! Please merge!

waitingsong commented 6 years ago 
C:/projects/myproject/src/lib/user32/api.ts:42:1
ERROR: 42:1  max-line-length  Exceeds maximum line length of 120

please fix

waitingsong commented 6 years ago

@TheNoim why do you change pkg.name and url of the package.json ? https://github.com/waitingsong/node-win32-api/pull/4/commits/1305ddf292454cee0bc3124fead1ffce2f428498

TheNoim commented 6 years ago

@waitingsong Sorry worked on a project and needed a quick version with this method which just works. This is why I republished it under win32-api-fork. Still hope this can be merge into this repo. Of course not with the changes I made to the package.json. A line length for this type of project does not make sense. If you add more win32 definitions later, of course will the file be longer than 120 lines. I suggest removing any line limitations.

waitingsong commented 6 years ago

@TheNoim You can insert a line before the definition

// @ts-ignore

to suppress the lint error