search

waiyan93 / web-scraping

0 stars 0 forks source link

Dependency management #10

Open olivierobert opened 2 years ago

olivierobert commented 2 years ago

Issue

While the UI is neat 💅 , there are a few puzzling areas of the frontend code when it comes to dependencies. First, both Bootstrap and Tailwind are defined as dependencies in package.json. One is used in resources/_ass/app.scss (which does not seem used 🤔 ) and the other one in resources/css/app.css. Wouldn't one CSS framework be sufficient? The same can be said for having both Alpine JS, Bootstrap JS, and Vue in JS resources/js/app.js 🤔

Expected

CSS and JS dependencies must be clearly finalized and trimmed down i.e., remove what is not used or needed.

waiyan93 commented 2 years ago

It is due to the scaffolding of the projects. Bootstrap come with the laravel-ui package when scaffolding the project to use Vue. Alpine JS and Tailwind come with the laravel breeze package when scaffolding the project to use Authentication. I will check and remove.