search

waiyan93 / web-scraping

0 stars 0 forks source link

Start of the code review process 👋 #6

Closed olivierobert closed 2 years ago

olivierobert commented 2 years ago

Hello Wai 👋 , thank you for your effort on the code submission. I am Olivier, CTO at Nimble, and I am happy to be the reviewer for our code review session. Long, one of our Engineering Leads was the one you met in the first interview and he shared with me your scorecard already.

During the review process, I would like to know more about your decisions and thus I will create issues where I think there could be more improvements regarding your performance here.

At the same time, please keep in mind that this is a bi-directional process and I would love to hear back from you as well. Therefore, don’t hesitate to raise your questions/concerns and share your opinions about the implementation (if any) during the process.

If we’re aligned on any issue here and you’d like to correct them, please address the issue using proper git-flow (creating a new branch, opening a Pull Request (PR) per issue, and merging the code when you are ready) and I will follow up on those fixes. 😇

In the end, I really do hope that you find the process enjoyable. Good luck and happy coding 🤘

olivierobert commented 2 years ago

@waiyan93 I completed the first round of reviews. Have a check 🙏

waiyan93 commented 2 years ago

Thanks sir. I will check it.

Best regards, Wai Yan Htet

On Mon, Apr 4, 2022 at 1:28 PM Olivier Robert @.***> wrote:

@waiyan93 https://github.com/waiyan93 I completed the first round of reviews. Have a check 🙏

— Reply to this email directly, view it on GitHub https://github.com/waiyan93/web-scraping/issues/6#issuecomment-1087184534, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEIBVN7PNYZX6AUZR36HWADVDKHKJANCNFSM5SON5UOA . You are receiving this because you were mentioned.Message ID: @.***>

olivierobert commented 2 years ago

@waiyan93 Thank you for working on doing changes to fix the open issues. However, as stated in the initial message, this is a bi-directional process and I would love to hear back from you on each issue. I expect you to at least provide your feedback and opinion on all the issues open. Without your feedback, my assessment will be incomplete.

olivierobert commented 2 years ago

@waiyan93 Thank you for your feedback on the open issues. Since we aim to keep the application process short in time, it is now time to conclude the code challenge review. Thank you for your efforts.

waiyan93 commented 2 years ago

Thanks you sir.

waiyan93 commented 2 years ago

Okay sir. I will.

Best regards, Wai Yan Htet

On Tue, Apr 5, 2022 at 1:49 PM Olivier Robert @.***> wrote:

@waiyan93 https://github.com/waiyan93 Thank you for working on doing changes to fix the open issues. However, as stated in the initial message, , this is a bi-directional process and I would love to hear back from you on each issue. I expect you to at least provide your feedback and opinion on all the issues open. Without your feedback, my assessment will be incomplete.

— Reply to this email directly, view it on GitHub https://github.com/waiyan93/web-scraping/issues/6#issuecomment-1088350300, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEIBVN4UR4XSYDWGS5DHVU3VDPSPVANCNFSM5SON5UOA . You are receiving this because you were mentioned.Message ID: @.***>