search

waka / activerecord-mysql-unsigned

Enable to use the "unsigned" option in the integer type for migrating of ActiveRecord
MIT License
31 stars 12 forks source link

[WIP]fix superclass mismatch for class ChangeColumnDefinition (TypeError) #23

Closed walf443 closed 9 years ago

walf443 commented 9 years ago

if you use this module with activerecord-mysql-awesome gem, some case occur TypeError.

So I prefer to just extend method signature.

walf443 commented 9 years ago

This PR will fail tests. It also fail same test on master. I try to research it in another PR.

walf443 commented 9 years ago

hmm. This change is not enough for fix problem. changed status to still work in progress.

walf443 commented 9 years ago

I ran it with rails's activerecord edge version. But it also fail this test.

https://travis-ci.org/walf443/activerecord-mysql-unsigned/jobs/48646346

https://github.com/walf443/activerecord-mysql-unsigned/commit/32333867956bf08b4e4e8f1082df43611a8af7de

walf443 commented 9 years ago

I'll close this issue. It may be my misunderstanding. SEE https://github.com/walf443/activerecord-mysql-unsigned/issues/1